Skip to content

build(deps): bump vimeo/psalm from 5.9.0 to 5.23.1 in /vendor-bin/psalm #44533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dependabot merged 18 commits into from
Apr 30, 2024
Merged

build(deps): bump vimeo/psalm from 5.9.0 to 5.23.1 in /vendor-bin/psalm #44533

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ce2d6cd
build(deps): bump vimeo/psalm from 5.9.0 to 5.23.1 in /vendor-bin/psalm
dependabot[bot] Mar 28, 2024
672923f
fix: Fix newly spotted psalm issues, add exhaustive typed magic prope…
come-nc Apr 22, 2024
26c4ca2
fix: Remove bogus code from query builder and fix parameter name
come-nc Apr 23, 2024
4c27e88
fix(files): Fix ownership transfer encrypted files detection
come-nc Apr 29, 2024
37262c8
fix(setupchecks): Fix opcache buffer check
come-nc Apr 29, 2024
c99ebaa
fix(theming): Fix erronous phpdoc typing
come-nc Apr 29, 2024
7f3fcbc
fix(user_ldap): Improve typing and fix a var name
come-nc Apr 29, 2024
b7acecd
fix: Fix default values for ini var in lib/base.php
come-nc Apr 29, 2024
d2de3e9
fix: Fix incorrect phpdoc typing in dav app
come-nc Apr 29, 2024
ece3588
fix: Improve typing of mimetype aliases
come-nc Apr 29, 2024
2333657
fix: Improve typing in Archive/TAR.php
come-nc Apr 29, 2024
4d06081
fix(files_external): Be extra safe with null handling to please psalm
come-nc Apr 29, 2024
0df6048
fix: Fix phpdoc typing in DirectEditing\Manager
come-nc Apr 29, 2024
85cea19
fix: Avoid useless reference usage in user_ldap
come-nc Apr 29, 2024
af728c5
fix: Fix tiny phpdoc errors related to Share
come-nc Apr 29, 2024
ed4603c
fix: Fix small psalm errors in legacy
come-nc Apr 29, 2024
eb25e10
fix: Avoid reference use in AppConfig
come-nc Apr 29, 2024
78e3462
chore: Update baseline to include new 3rdparty psalm errors
come-nc Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Avoid reference use in AppConfig 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Apr 30, 2024
commit eb25e10f5590d48400af1f7c99f7a363bd9394df
10 changes: 4 additions & 6 deletions lib/private/AppConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,11 +850,10 @@ private function setTypedValue(

// update local cache
if ($lazy) {
$cache = &$this->lazyCache;
$this->lazyCache[$app][$key] = $value;
} else {
$cache = &$this->fastCache;
$this->fastCache[$app][$key] = $value;
}
$cache[$app][$key] = $value;
$this->valueTypes[$app][$key] = $type;

return true;
Expand Down Expand Up @@ -1264,11 +1263,10 @@ private function loadConfig(?bool $lazy = false): void {
foreach ($rows as $row) {
// most of the time, 'lazy' is not in the select because its value is already known
if (($row['lazy'] ?? ($lazy ?? 0) ? 1 : 0) === 1) {
$cache = &$this->lazyCache;
$this->lazyCache[$row['appid']][$row['configkey']] = $row['configvalue'] ?? '';
} else {
$cache = &$this->fastCache;
$this->fastCache[$row['appid']][$row['configkey']] = $row['configvalue'] ?? '';
}
$cache[$row['appid']][$row['configkey']] = $row['configvalue'] ?? '';
$this->valueTypes[$row['appid']][$row['configkey']] = (int)($row['type'] ?? 0);
}
$result->closeCursor();
Expand Down