fix(tests): Fix tests when daytime saving time change happened recently

[come-nc]

Summary

Fix the quite corner case we are currently having in CI: recent daytime saving time change in Europe is making the share date expiration test fail.
Somehow the tests are also not correctly independent and having this one fail messed up 6 others, by leaving behind a hook expectation it seems.

The bug comes from the order of timezone change and day removal, if you change timezone first and remove 2 days after you do not get the same hours as if you do it the other way around.
Can be tested with this:

<?php

$timezone = new \DateTimeZone('Pacific/Auckland');
$nextWeek = new \DateTime('now', $timezone);
$nextWeek->add(new \DateInterval('P7D'));

$save = clone $nextWeek;
$save->setTime(0, 0);
$save->sub(new \DateInterval('P2D'));
$save->setTimezone(new \DateTimeZone(date_default_timezone_get()));

$save2 = clone $nextWeek;
$save2->setTime(0, 0);
$save2->setTimezone(new \DateTimeZone(date_default_timezone_get()));
$save2->sub(new \DateInterval('P2D'));
		
var_dump(
    $nextWeek,
    $save,
    $save2,
);

Current output (on 2024-04-02):

object(DateTime)#2 (3) {
  ["date"]=>
  string(26) "2024-04-09 22:29:22.491335"
  ["timezone_type"]=>
  int(3)
  ["timezone"]=>
  string(16) "Pacific/Auckland"
}
object(DateTime)#3 (3) {
  ["date"]=>
  string(26) "2024-04-06 13:00:00.000000"
  ["timezone_type"]=>
  int(3)
  ["timezone"]=>
  string(16) "Europe/Amsterdam"
}
object(DateTime)#4 (3) {
  ["date"]=>
  string(26) "2024-04-06 14:00:00.000000"
  ["timezone_type"]=>
  int(3)
  ["timezone"]=>
  string(16) "Europe/Amsterdam"
}

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

/backport to stable29

[come-nc]

/backport to stable28

[come-nc]

/backport to stable27

[backportbot]

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/44612/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fda1c42a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44612/stable29

Error: Failed to push branch backport/44612/stable29: fatal: could not read Username for 'https://github.com': No such device or address

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[come-nc]

/backport to stable29