Skip to content

fix(federation): ICloudId->getRemote() should contain the protocol #44625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Apr 2, 2024
Merged

fix(federation): ICloudId->getRemote() should contain the protocol #44625

nickvergessen merged 1 commit into from
Apr 2, 2024

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 2, 2024

Summary

the getRemote() field should always contain the protocol as it's used directly in web requests, only the visible cloudId should have https:// stripped out.

Checklist

@nickvergessen nickvergessen self-assigned this Apr 2, 2024
@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 2, 2024

/backport! to stable29

@backportbot backportbot bot mentioned this pull request Apr 2, 2024
Merged
SystemKeeper
SystemKeeper approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - saw a similar report in the community

@nickvergessen nickvergessen merged commit 43204a0 into master Apr 2, 2024
@nickvergessen nickvergessen deleted the bugfix/44608/fix-remote-of-cloudid-being-with-protocol branch April 2, 2024 20:03
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Apr 2, 2024
@nickvergessen nickvergessen mentioned this pull request Jun 26, 2024
Merged
4 tasks
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: federation regression

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

Undefined array key 1 at apps/files_sharing/lib/External/Cache.php#41

7 participants

@nickvergessen @ArtificialOwl @SystemKeeper @blizzz @juliusknorr @AndyScherzinger