Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 4, 2024

Checklist

@nickvergessen
Copy link
Member

Psalm error is related:

apps/files_external/lib/MountConfig.php:260:12: InternalMethod: The method phpseclib\Crypt\Base::setKey is internal to phpseclib but called from OCA\Files_External\MountConfig::getCipher

@susnux
Copy link
Contributor Author

susnux commented Apr 4, 2024

@nickvergessen I think this can be ignored in our baseline as this is introduced by removing the extending setKey and falling back to Base::setKey. Reported this behavior change upstream: phpseclib/phpseclib#1990

We already do this for setIV, encrypt and decrypt of that file.

@susnux susnux force-pushed the fix/update-phpsec branch from c6e0e82 to 1875d8e Compare April 4, 2024 21:28
@susnux susnux force-pushed the fix/update-phpsec branch from 1875d8e to 5c8baa5 Compare April 5, 2024 10:32
@susnux susnux requested a review from Altahrim April 5, 2024 10:33
@susnux
Copy link
Contributor Author

susnux commented Apr 5, 2024

Adjusted 3rdparty submodule, PR ready now ✔️

@susnux

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

@skjnldsv skjnldsv merged commit 5afd2d8 into master Apr 5, 2024
@skjnldsv skjnldsv deleted the fix/update-phpsec branch April 5, 2024 11:53
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants