fix(groups): allows to save group names with more than 64 characters #44763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
added
bug
3. to review
Altahrim
requested review from
come-nc,
icewind1991,
sorbaugh and
yemkareems
and removed request for
a team
Collaborator
Author
|
/backport to stable29 |
Collaborator
Author
|
/backport to stable28 |
Collaborator
Author
|
/backport to stable27 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Altahrim
force-pushed
the
fix/group_name_length_db
branch
from
4c300d7 to
821a545
Compare
come-nc
reviewed
Apr 11, 2024
Altahrim
force-pushed
the
fix/group_name_length_db
branch
3 times, most recently
from
89a8d06 to
e787b14
Compare
Altahrim
force-pushed
the
fix/group_name_length_db
branch
from
e787b14 to
aff8568
Compare
Altahrim
force-pushed
the
fix/group_name_length_db
branch
from
aff8568 to
60bd409
Compare
come-nc
reviewed
Apr 22, 2024
Altahrim
force-pushed
the
fix/group_name_length_db
branch
from
60bd409 to
da168a9
Compare
come-nc
reviewed
Apr 22, 2024
Mimic behaviour from LDAP users and add a hard limit to 255 characters Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
fix/group_name_length_db
branch
from
da168a9 to
7a6b1f8
Compare
come-nc
approved these changes
Apr 30, 2024
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I think I would prefer string|false instead of ?string, or string and exception throwing. I did not check what is most consistent with the rest of OCP though.
artonge
approved these changes
May 16, 2024
Collaborator
Author
|
/backport to stable29 |
Collaborator
Author
|
/backport to stable28 |
Collaborator
Author
|
/backport to stable27 |
2 tasks
nickvergessen
added
the
pending documentation
|
|
||
| /** | ||
| * @since 14.0.0 | ||
| * @deprecated 30.0.0 Use ICreateNamedGroupBackend instead |
Member
There was a problem hiding this comment.
@Altahrim Please document in https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.html#id1
(all changes in lib/public/)
Merged
Altahrim
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mimic behaviour from LDAP users and add a hard limit to 255 characters
Checklist