Skip to content

fix(LDAP): do not count mapped users x-times active configs #44767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
blizzz wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(LDAP): do not count mapped users x-times active configs #44767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(LDAP): do not count mapped users x-times active configs 
- the method counts all rows in the mapping tables, which are not
  specific to single configurations, but contains users from all

Signed-off-by: Arthur Schiwon <[email protected]>
  • Loading branch information
@blizzz
blizzz committed Apr 10, 2024
commit 9beb5a90ea6d81235d148f7e27282a4a9a83353a
7 changes: 1 addition & 6 deletions apps/user_ldap/lib/User_Proxy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,12 +415,7 @@ public function countUsers() {
*/
public function countMappedUsers(): int {
$this->setup();

$users = 0;
foreach ($this->backends as $backend) {
$users += $backend->countMappedUsers();
}
return $users;
return $this->refBackend?->countMappedUsers() ?? 0;
}

/**
Expand Down