Skip to content

fix(notifications): Improved notification exceptions #44770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 6 commits into from
Apr 15, 2024
Merged

fix(notifications): Improved notification exceptions #44770

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
834bd13
fix(notifications): Add a dedicated exception when invalid values are…
nickvergessen Apr 10, 2024
2c6ecef
fix(notifications): Add a dedicated exception when not all fields are…
nickvergessen Apr 10, 2024
c8e4a29
fix(notifications): Add a dedicated exception when the notification i…
nickvergessen Apr 10, 2024
0d0c2cd
fix(notifications): Add a dedicated exception when a notification was…
nickvergessen Apr 10, 2024
6545fed
fix(notifications): Throw AlreadyProcessedException also from the man…
nickvergessen Apr 10, 2024
8745254
fix(notifications): Add a warning when using relative links
nickvergessen Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(notifications): Throw AlreadyProcessedException also from the man… 
…ager when it's done

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Apr 12, 2024
commit 6545fed34ad8061c293f3975801eb4ff9eea10f2
2 changes: 1 addition & 1 deletion lib/private/Notification/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ public function prepare(INotification $notification, string $languageCode): INot
$notification = $notifier->prepare($notification, $languageCode);
} catch (AlreadyProcessedException $e) {
$this->markProcessed($notification);
throw new \InvalidArgumentException('The given notification has been processed');
throw $e;
} catch (UnknownNotificationException) {
continue;
} catch (\InvalidArgumentException $e) {
Expand Down