Skip to content

[stable28] fix(files): Inherit some node attributes when creating new nodes to preserve shared state #44844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 3 commits into from
Apr 16, 2024
Merged

[stable28] fix(files): Inherit some node attributes when creating new nodes to preserve shared state #44844

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3091c31
fix(files): Sanitize `share-types` attribute in download action
susnux Apr 15, 2024
df3b2eb
fix(files): Inherit some node attributes when creating new nodes to p…
susnux Apr 15, 2024
96e200f
chore(assets): Recompile assets
nextcloud-command Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): Sanitize share-types attribute in download action 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @backportbot
susnux authored and backportbot[bot] committed Apr 16, 2024
commit 3091c31d6e57036b0d588b75aaa2c7e0ab2f18a5
3 changes: 2 additions & 1 deletion apps/files/src/actions/downloadAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ const isDownloadable = function(node: Node) {

// If the mount type is a share, ensure it got download permissions.
if (node.attributes['mount-type'] === 'shared') {
const downloadAttribute = JSON.parse(node.attributes['share-attributes']).find((attribute: { scope: string; key: string }) => attribute.scope === 'permissions' && attribute.key === 'download')
const shareAttributes = JSON.parse(node.attributes['share-attributes'] ?? 'null')
const downloadAttribute = shareAttributes?.find?.((attribute: { scope: string; key: string }) => attribute.scope === 'permissions' && attribute.key === 'download')
if (downloadAttribute !== undefined && downloadAttribute.enabled === false) {
return false
}
Expand Down