Skip to content

fix(files): Focus filename input in new-node dialog when opened #44847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 2 commits into from
Apr 16, 2024
Merged

fix(files): Focus filename input in new-node dialog when opened #44847

susnux merged 2 commits into from
Apr 16, 2024

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 16, 2024

Summary

Always focus the filename input when the dialog is opened

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Apr 16, 2024
@susnux susnux requested a review from skjnldsv as a code owner April 16, 2024 11:01
@susnux susnux requested review from a team, ChristophWurst, emoral435, kesselb and szaimen and removed request for a team April 16, 2024 11:01
@susnux
Copy link
Contributor Author

susnux commented Apr 16, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Apr 16, 2024

/backport to stable28

ChristophWurst
ChristophWurst approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 🙏

szaimen
szaimen approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work :)

@susnux susnux enabled auto-merge April 16, 2024 11:50
@susnux susnux merged commit 33c4ddd into master Apr 16, 2024
@susnux susnux deleted the fix/files-focus-new-node-dialog branch April 16, 2024 11:57
This was referenced Apr 16, 2024
Merged
Merged
@kesselb
Copy link
Contributor

kesselb commented Apr 16, 2024

Thank you 👍

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@kesselb kesselb Awaiting requested review from kesselb

@emoral435 emoral435 Awaiting requested review from emoral435 emoral435 is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: files feedback-requested

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

[Bug]: New file name modal does not always set focus

5 participants

@susnux @kesselb @ChristophWurst @szaimen