-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Support multiple scopes in DAV search #44858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple scopes in DAV search #44858
Conversation
e168062 to
3cba742
Compare
3cba742 to
91e6cdd
Compare
icewind1991
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is only a single folder, doing the search on the folder is more efficient as it can filter down the storages it searches in
e3a9de0 to
817ac06
Compare
0e6b256 to
8709037
Compare
3c42472 to
784e43b
Compare
| * @param Query $search | ||
| * @return SearchResult[] | ||
| */ | ||
| public function search(Query $search): array { |
Check notice
Code scanning / Psalm
ParamNameMismatch
Signed-off-by: Louis Chemineau <[email protected]>
784e43b to
ac0acfb
Compare
emoral435
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. In terms of optimization, I am generally unknowledgeable here, but the code logic makes sense :)
|
/backport to stable29 |
Instead of making the search on the targeted folders, the current approach does it on the user's root folder, with some extra conditions applied on the path.
This allows the following scope in WebDAV
SEARCHrequests:This can be tested with the following PR in Photos: nextcloud/photos#2426
With that PR, the SQL request will look like that: