Skip to content

fix(activity): Improved activity exceptions #44886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 5 commits into from
Apr 18, 2024
Merged

fix(activity): Improved activity exceptions #44886

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
661143a
fix(activity): Add a dedicated exception when invalid values are set
nickvergessen Apr 17, 2024
8f83953
fix(activity): Add a dedicated exception when not all fields are set …
nickvergessen Apr 17, 2024
784ab6e
fix(activity): Add a dedicated exception when the event is unknown to…
nickvergessen Apr 17, 2024
9f4845e
fix(activity): Add a dedicated exception when the filter or setting i…
nickvergessen Apr 17, 2024
17744f8
fix(activity): Remove unneeded exception (types are enforced)
nickvergessen Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(activity): Remove unneeded exception (types are enforced) 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Apr 17, 2024
commit 17744f8590513e6a1d0e2a19a101b5f6e7332fcc
4 changes: 0 additions & 4 deletions lib/private/Activity/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,12 +334,8 @@ public function getRequirePNG(): bool {
* Set the user we need to use
*
* @param string|null $currentUserId
* @throws \UnexpectedValueException If the user is invalid
*/
public function setCurrentUserId(?string $currentUserId = null): void {
if (!is_string($currentUserId) && $currentUserId !== null) {
throw new \UnexpectedValueException('The given current user is invalid');
}
$this->currentUserId = $currentUserId;
}

Expand Down
1 change: 0 additions & 1 deletion lib/public/Activity/IManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ public function getRequirePNG(): bool;
* Set the user we need to use
*
* @param string|null $currentUserId
* @throws \UnexpectedValueException If the user is invalid
* @since 9.0.1
*/
public function setCurrentUserId(?string $currentUserId = null): void;
Expand Down