fix(files): Also restore shares after ownership transfer for object storage #44904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Background information: Currently our file system does not support moving files between storages, so we need to hack this here. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
susnux
force-pushed
the
fix/transfer-ownership
branch
from
3a26dda to
e2a3144
Compare
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable27 |
…torage When a file is moved between different storages then the file id is not (always) preserved. This means the file id has to be adjusted for all shares. So in case the file id does not exist anymore we try to find the new file id based on the target path of the transfer and the path suffix of the share. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/transfer-ownership
branch
from
e2a3144 to
38f4451
Compare
Altahrim
approved these changes
Apr 18, 2024
artonge
approved these changes
Apr 18, 2024
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Band-aid, but should works 👍
This was referenced Apr 18, 2024
Merged
Merged
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a file is moved between different storages then the file id is not (always) preserved. This means the file id has to be adjusted for all shares.
So in case the file id does not exist anymore we try to find the new file id based on the target path of the transfer and the path suffix of the share.
Checklist