Skip to content

[stable28] fix: regression with updating read-only config #44926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Jun 7, 2024
Merged

[stable28] fix: regression with updating read-only config #44926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: regression with updating read-only config 
Signed-off-by: Sam Bull <[email protected]>
  • Loading branch information
@Dreamsorcerer @backportbot
Dreamsorcerer authored and backportbot[bot] committed Apr 18, 2024
commit 6ff1f464ce8591e734562de8fe0443fb2934a1e4
4 changes: 0 additions & 4 deletions lib/private/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ public function setValue($key, $value) {
* @throws HintException
*/
protected function set($key, $value) {
$this->checkReadOnly();

if (!isset($this->cache[$key]) || $this->cache[$key] !== $value) {
// Add change
$this->cache[$key] = $value;
Expand Down Expand Up @@ -185,8 +183,6 @@ public function deleteKey($key) {
* @throws HintException
*/
protected function delete($key) {
$this->checkReadOnly();

if (isset($this->cache[$key])) {
// Delete key from cache
unset($this->cache[$key]);
Expand Down