fix: update last_login timestamp for token based-logins #45020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noodlesalat
force-pushed
the
fix-lastlogin-update-token-login
branch
2 times, most recently
from
59c4b24 to
b84a5dd
Compare
Merged
juliusknorr
approved these changes
Aug 16, 2024
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Looks good, last login is also debounced for 60 seconds so this should be fine performance wise.
juliusknorr
force-pushed
the
fix-lastlogin-update-token-login
branch
from
b84a5dd to
34721df
Compare
fixes nextcloud#31075 and maybe nextcloud#32953 Signed-off-by: Fabian Dreßler <[email protected]>
joshtrichards
force-pushed
the
fix-lastlogin-update-token-login
branch
from
34721df to
1d6cce8
Compare
skjnldsv
approved these changes
Sep 17, 2024
Contributor
|
Could we backport this very useful fix? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the last login timestamp of a user is only updated when he logs in with his password. Since token-based logins do not update the timestamp, it may appear as if the user is inactive although he is regularly logged in with token-based clients (desktop client, mobile app, ...).
For this reason, the last_login timestamp should be updated for each individual login.
Checklist