Skip to content

Education "bundle" #45091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Aug 6, 2024
Merged

Education "bundle" #45091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/e2e/settings/apps.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ describe('Settings: App management', { testIsolation: true }, () => {
cy.get('#app-category-your-bundles').find('.active').should('exist')
// I see the app bundles
cy.get('#apps-list').contains('tr', 'Enterprise bundle')
cy.get('#apps-list').contains('tr', 'Education Edition')
cy.get('#apps-list').contains('tr', 'Education bundle')
// I see that the "Enterprise bundle" is disabled
cy.get('#apps-list').contains('tr', 'Enterprise bundle').contains('button', 'Download and enable all')
})
Expand Down
2 changes: 1 addition & 1 deletion lib/private/App/AppStore/Bundles/EducationBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class EducationBundle extends Bundle {
* {@inheritDoc}
*/
public function getName() {
return $this->l10n->t('Education Edition');
return $this->l10n->t('Education bundle');
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/App/AppStore/Bundles/EducationBundleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ protected function setUp(): void {
parent::setUp();
$this->bundle = new EducationBundle($this->l10n);
$this->bundleIdentifier = 'EducationBundle';
$this->bundleName = 'Education Edition';
$this->bundleName = 'Education bundle';
$this->bundleAppIds = [
'dashboard',
'circles',
Expand Down