Skip to content

fix(session): Avoid race condition for cache::get() vs. cache::hasKey() #45093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
May 6, 2024
Merged

fix(session): Avoid race condition for cache::get() vs. cache::hasKey() #45093

nickvergessen merged 1 commit into from
May 6, 2024

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 29, 2024 •
edited
Loading

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Apr 29, 2024
@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Apr 29, 2024
@nickvergessen nickvergessen self-assigned this Apr 29, 2024
@ChristophWurst
Copy link
Member

ChristophWurst commented Apr 29, 2024

/backport to stable29

@ChristophWurst
Copy link
Member

ChristophWurst commented Apr 29, 2024

/backport to stable28

@ChristophWurst ChristophWurst mentioned this pull request Apr 29, 2024
Merged
3 tasks
@SystemKeeper SystemKeeper mentioned this pull request May 1, 2024
Closed
8 tasks
@nickvergessen
Copy link
Member Author

nickvergessen commented May 6, 2024

Seems to solve the issue, so merging

@nickvergessen nickvergessen merged commit 2c2c373 into master May 6, 2024
@nickvergessen nickvergessen deleted the bugfix/noid/avoid-getKey-race-condition branch May 6, 2024 06:13
This was referenced May 6, 2024
Merged
Merged
@jerome-micucci
Copy link

jerome-micucci commented May 15, 2024

It's work like a charm with 28.0.5

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Altahrim Altahrim Altahrim approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@come-nc come-nc come-nc approved these changes

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: authentication

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

8 participants

@nickvergessen @ChristophWurst @jerome-micucci @Altahrim @juliusknorr @come-nc @joshtrichards