Refactors theming app - part 4 #45146
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @return string|false image blob | ||
| */ | ||
| public function getFavicon($app) { | ||
| public function getFavicon($app): bool|string { |
Check notice
Code scanning / Psalm
MissingParamType
| * @return string|false image blob | ||
| */ | ||
| public function getTouchIcon($app) { | ||
| public function getTouchIcon($app): bool|string { |
Check notice
Code scanning / Psalm
MissingParamType
| * @return Imagick|false | ||
| */ | ||
| public function renderAppIcon($app, $size) { | ||
| public function renderAppIcon($app, $size): Imagick|bool { |
Check notice
Code scanning / Psalm
MissingParamType
| * @return Imagick|false | ||
| */ | ||
| public function renderAppIcon($app, $size) { | ||
| public function renderAppIcon($app, $size): Imagick|bool { |
Check notice
Code scanning / Psalm
MissingParamType
| * @return string|false content of a colorized svg file | ||
| */ | ||
| public function colorSvg($app, $image) { | ||
| public function colorSvg($app, $image): bool|string { |
Check notice
Code scanning / Psalm
MissingParamType
| * @return string|false content of a colorized svg file | ||
| */ | ||
| public function colorSvg($app, $image) { | ||
| public function colorSvg($app, $image): bool|string { |
Check notice
Code scanning / Psalm
MissingParamType
| public function getImprintUrl() { | ||
| return (string)$this->config->getAppValue('theming', 'imprintUrl', ''); | ||
| public function getImprintUrl(): string { | ||
| return $this->config->getAppValue('theming', 'imprintUrl', ''); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| public function getPrivacyUrl() { | ||
| return (string)$this->config->getAppValue('theming', 'privacyUrl', ''); | ||
| public function getPrivacyUrl(): string { | ||
| return $this->config->getAppValue('theming', 'privacyUrl', ''); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| public function getDocBaseUrl() { | ||
| return (string)$this->config->getAppValue('theming', 'docBaseUrl', $this->docBaseUrl); | ||
| public function getDocBaseUrl(): string { | ||
| return $this->config->getAppValue('theming', 'docBaseUrl', $this->docBaseUrl); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| * @return string base64 encoded radio button svg | ||
| */ | ||
| public function generateRadioButton($color) { | ||
| public function generateRadioButton($color): string { |
Check notice
Code scanning / Psalm
MissingParamType
… property promotion feature. Signed-off-by: Faraz Samapoor <[email protected]>
fsamapoor
force-pushed
the
refactor_theming_app_part4
branch
from
e94860a to
407e780
Compare
fsamapoor
requested review from
a team,
ArtificialOwl,
icewind1991 and
yemkareems
and removed request for
a team
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
|
Hey @fsamapoor closing, there's too much conflicts and/or changes got applied already via another PR. We're slowly deploying rector that should help us continuing the refactoring on the long run! Have a lovely day!! |
3 participants
Summary
Following previous PRs taking advantage of PHP8's constructor property promotion, I have also made the required adjustments to the classes in the
themingapp.I decided to split the changes into multiple PRs to make reviewing the changes easier.
The improvements in this PR include but are not limited to:
Checklist