Skip to content

[stable29] fix(settings): Save one HTTP request on enabling an app #45204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
May 6, 2024
Merged

[stable29] fix(settings): Save one HTTP request on enabling an app #45204

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14a0d05
fix(settings): When testing server stability, request URL with traili…
susnux Apr 19, 2024
cd44613
chore: Compile assets
susnux Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(settings): When testing server stability, request URL with traili… 
…ng slash

This prevents one HTTP request for most situations (301 from `apps/files` to `apps/files/`)
and helps users with faulty reverse-proxy configuration.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @backportbot
susnux authored and backportbot[bot] committed May 6, 2024
commit 14a0d0534a13e1944fdf3858bda1824c4ab09d78
2 changes: 1 addition & 1 deletion apps/settings/src/store/apps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ const actions = {
})

// check for server health
return api.get(generateUrl('apps/files'))
return api.get(generateUrl('apps/files/'))
.then(() => {
if (response.data.update_required) {
showInfo(
Expand Down