Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented May 6, 2024

Backport of PR #45055

This was referenced May 15, 2024
@joshtrichards joshtrichards force-pushed the backport/45055/stable29 branch from b8eace4 to 0d16ef9 Compare May 28, 2024 21:43
@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 28, 2024
@susnux susnux force-pushed the backport/45055/stable29 branch from 0d16ef9 to 9bea6ec Compare May 29, 2024 08:31
@joshtrichards
Copy link
Member

@AndyScherzinger I saw you moved the milestone from 29.0.1 -> 29.0.3 on this one yesterday. It's ready to merge. Do we want to hold this for some reason from 29.0.2?

@AndyScherzinger
Copy link
Member

I saw you moved the milestone from 29.0.1 -> 29.0.3 on this one yesterday. It's ready to merge. Do we want to hold this for some reason from 29.0.2?

No reason except RC is already being built as we speak, hence I shifted it to 29.0.3, since we try to not merge PRs after the first RC has been built.

@AndyScherzinger
Copy link
Member

I'll talk to @Altahrim if we can do another RC and have it in

@Altahrim Altahrim mentioned this pull request May 29, 2024
@Altahrim Altahrim merged commit 8479dfa into stable29 May 29, 2024
@Altahrim Altahrim deleted the backport/45055/stable29 branch May 29, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants