Skip to content

fix(setupChecks): update db version checks #45241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 6 commits into from
May 11, 2024
Merged

fix(setupChecks): update db version checks #45241

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2abd67c
fix(setupChecks): update db version checks
joshtrichards May 9, 2024
f486be8
fix: only compare minor mariadb version differences
joshtrichards May 10, 2024
3ce8c6d
fix: refactor postgresql check to match mariadb/mysql
joshtrichards May 10, 2024
2e94ec8
fix: only compare major version of pgsql
joshtrichards May 10, 2024
7d7ae25
fix(phpunit-pgsql): master/v30 only supports pgsql 12-16; drop 10
joshtrichards May 10, 2024
2915714
fix: oops vendor string embedded in version
joshtrichards May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: refactor postgresql check to match mariadb/mysql 
Signed-off-by: Josh Richards <[email protected]>
  • Loading branch information
@joshtrichards
joshtrichards committed May 10, 2024
commit 3ce8c6d0db2124e9079407073eaabd3bb42d26cb
3 changes: 2 additions & 1 deletion apps/settings/lib/SetupChecks/SupportedDatabase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ public function run(): SetupResult {
$result->execute();
$row = $result->fetch();
$version = $row['server_version'];
if (version_compare(strtolower($version), '12', '<') || version_compare(strtolower($version, '16', '>') {
$versionlc = strtolower($version);
if (version_compare($versionlc, '12', '<') || version_compare($versionlc, '16', '>')) {
return SetupResult::warning($this->l10n->t('PostgreSQL version "%s" detected. PostgreSQL >=12 and <=16 is suggested for best performance, stability and functionality with this version of Nextcloud.', $version));
}
} elseif ($databasePlatform instanceof OraclePlatform) {
Expand Down