Skip to content

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented May 10, 2024

  • Resolves: #

Summary

TODO

  • ...

Checklist

Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger added 4. to release Ready to be released and/or waiting for tests to finish technical debt labels May 10, 2024
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone May 10, 2024
@AndyScherzinger AndyScherzinger merged commit fc6e9e4 into master May 10, 2024
@AndyScherzinger AndyScherzinger deleted the chore/noid/spdx-revert-rename branch May 10, 2024 11:46
@kesselb
Copy link
Contributor

kesselb commented May 10, 2024

The CI for this pull request should have failed because https://github.com/nextcloud/server/blob/master/build/files-checker.php was not adjusted.

PHP checkers was skipped: https://github.com/nextcloud/server/actions/runs/9031734812/job/24818556719?pr=45250

Workflow: https://github.com/nextcloud/server/blob/master/.github/workflows/autocheckers.yml#L81-L82

I guess we need to adjust the workflow to also run for rename or let the files-checker always run.

AndyScherzinger added a commit that referenced this pull request May 10, 2024
see #45250

Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger mentioned this pull request May 10, 2024
5 tasks
@AndyScherzinger
Copy link
Member Author

see #45256 for fixing this list of expected files and folders

@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants