Skip to content

[stable29] Avoid updating the same oc_authtoken row twice #45348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 3 commits into from
Jun 6, 2024
Merged

[stable29] Avoid updating the same oc_authtoken row twice #45348

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9058428
docs: Update token_auth_activity_update default value to match implem…
juliusknorr Apr 25, 2024
c647f89
fix: Always set last activity if we update the row of an authtoken an…
juliusknorr Apr 25, 2024
ce339b3
fix(auth): Update authtoken activity selectively
ChristophWurst May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Always set last activity if we update the row of an authtoken an… 
…yways

Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr @kesselb
juliusknorr authored and kesselb committed Jun 6, 2024
commit c647f892961135605d3d9445f945cc2021410dbe
2 changes: 2 additions & 0 deletions lib/private/Authentication/Token/PublicKeyTokenProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,8 @@ public function updateToken(OCPIToken $token) {
if (!($token instanceof PublicKeyToken)) {
throw new InvalidTokenException("Invalid token type");
}
$now = $this->time->getTime();
$token->setLastActivity($now);
$this->mapper->update($token);
$this->cacheToken($token);
}
Expand Down