feat(setupcheck): Check several config values to be valid URLs (and more) #45382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore) Signed-off-by: Joas Schilling <[email protected]>
4 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (filter_var($parts[0], FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) { | ||
| if (!is_numeric($parts[1]) || $parts[1] > 32 || $parts[1] < 1) { |
Check notice
Code scanning / Psalm
PossiblyUndefinedArrayOffset
| return SetupResult::error($this->l10n->t('Config value %s is not an valid IP address or IP range.', [$configKey])); | ||
| } | ||
| } elseif (filter_var($parts[0], FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) { | ||
| if (!is_numeric($parts[1]) || $parts[1] > 128 || $parts[1] < 1) { |
Check notice
Code scanning / Psalm
PossiblyUndefinedArrayOffset
Contributor
|
Good idea 👍 Some people were confused with the well-known setup check because it stops on the first failure. I fear this could be confusing here as well if you encounter many issues in the configuration file. |
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trusted_domainsandoverwrite.cli.urlsensitive config values #45085TODO
Checklist