Skip to content

fix(files): Don't fail if dir exists #45413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
May 30, 2024
Merged

fix(files): Don't fail if dir exists #45413

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4e4c5
fix(files): Try to create dir only if it not exists
solracsf May 21, 2024
77979b1
Try create folder first and check if it exists after
solracsf May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): Try to create dir only if it not exists 
Signed-off-by: Git'Fellow <[email protected]>
  • Loading branch information
@solracsf @artonge
solracsf authored and artonge committed May 30, 2024
commit 5c4e4c55907cad96410ac77547115f03c4adfdd3
2 changes: 1 addition & 1 deletion lib/private/Files/Node/Folder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public function newFolder($path) {
$fullPath = $this->getFullPath($path);
$nonExisting = new NonExistingFolder($this->root, $this->view, $fullPath);
$this->sendHooks(['preWrite', 'preCreate'], [$nonExisting]);
if (!$this->view->mkdir($fullPath)) {
if (!$this->view->is_dir($fullPath) && !$this->view->mkdir($fullPath)) {
throw new NotPermittedException('Could not create folder "' . $fullPath . '"');
}
$parent = dirname($fullPath) === $this->getPath() ? $this : null;
Expand Down