[stable27] fix(theming): stable 27 disable accessible color config switch

[skjnldsv]

Fix #39551

Only for 27! 28 and above have a different handling of themes and is fixed

Apply this fix

1. add '27-disable-accessible-theming-color' => true, to your config.php
2. delete the global folder on your data/appdata_xxxx/theming directory (no need to delete the theming folder)
3. run an occ files:scan-app-data theming

How to reproduce the issue

1. use a non accessible color like #004352
2. load the files app

Before	After

[szaimen]

28 and above have a different handling of themes and is fixed

I fear it is not, seems to behave completely the same, just tested (it still adjusts the color to an accessible one)...

---

primary color (black):

folder color (grey):

[artonge]

folder color (grey):

But that is expected, no? Black on black does not work for accessibility.

[szaimen]

folder color (grey):

But that is expected, no? Black on black does not work for accessibility.

yes, this is also what I am understanding but seems like the customer complains about exactly this, no?

[AndyScherzinger]

yes, this is also what I am understanding but seems like the customer complains about exactly this, no?

No the complaint is the before image which shows the folder color used for dark and light

[skjnldsv]

yes, this is also what I am understanding but seems like the customer complains about exactly this, no?

No the complaint is the before image which shows the folder color used for dark and light

28 with the color above:

EDIT: @AndyScherzinger the colour shift is till being done, but the computation is different to be accessible.
We might have to check with the customer again that they're ok with it

[szaimen]

yes, this is also what I am understanding but seems like the customer complains about exactly this, no?

No the complaint is the before image which shows the folder color used for dark and light

I see. 👍

[AndyScherzinger]

We might have to check with the customer again that they're ok with it

Yes, we might. The main issue is with the light theme though. The light folder icons in your before screenshot are also used in light mode on 27...

So the main issue to be addressed with this fix is:

[AndyScherzinger]

@skjnldsv how would the light theme look like in 28 with that color? That is the main concern with the given color code

[skjnldsv]

@skjnldsv how would the light theme look like in 28 with that color? That is the main concern with the given color code

Because we fixed the computation on the client side, so we now which theme is active 👍

[AndyScherzinger]

Sweet, so v28 looks good to me 👍
Can't tell if this works fine with they background image as already mentioned by @artonge to me.