fix(INavigationManager): Fix psalm alias not set in the right place #45455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
commented
May 22, 2024
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/psalm/navigation-entries
branch
from
489059e to
0d202e2
Compare
susnux
approved these changes
May 30, 2024
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable29 |
come-nc
approved these changes
Jun 3, 2024
This was referenced Jun 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#41341 didn't set the type alias correctly as it needs to be on the same class to be "visible" (PHPStorm also displays that it can't resolve the type on the add method).
While looking at that I also found that the type for the endpoint is wrong and was missing some fields as well (guess who did that 😅).
Checklist