Skip to content

[stable28] fix: forbid moving a folder into a subfolder of itself #45528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Jun 7, 2024
Merged

[stable28] fix: forbid moving a folder into a subfolder of itself #45528

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1e53c6
fix: forbid moving a folder into a subfolder of itself
icewind1991 Apr 24, 2024
91c1d0b
Fix backport
solracsf May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix backport 
Signed-off-by: Git'Fellow <[email protected]>
  • Loading branch information
@solracsf
solracsf authored May 28, 2024
commit 91c1d0bf7e7147cb422d1b71d4c1e52e3e1448a3
5 changes: 5 additions & 0 deletions lib/private/Files/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,11 @@ public function deleteAll($directory) {
public function rename($source, $target) {
$absolutePath1 = Filesystem::normalizePath($this->getAbsolutePath($source));
$absolutePath2 = Filesystem::normalizePath($this->getAbsolutePath($target));

if (str_starts_with($absolutePath2, $absolutePath1 . '/')) {
throw new ForbiddenException("Moving a folder into a child folder is forbidden", false);
}

$result = false;
if (
Filesystem::isValidPath($target)
Expand Down