Skip to content

Conversation

@icewind1991
Copy link
Member

Instead of deleting by job name and arguments.

This should both improve performance and reduce the risk of deadlocks

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 30, 2024
@icewind1991 icewind1991 added this to the Nextcloud 30 milestone May 30, 2024
@icewind1991 icewind1991 requested review from a team, nfebe, sorbaugh and yemkareems and removed request for a team May 30, 2024 13:18
@susnux susnux requested review from come-nc and removed request for sorbaugh June 10, 2024 09:48
@icewind1991 icewind1991 requested a review from artonge June 14, 2024 12:27
@icewind1991 icewind1991 merged commit 642cffd into master Jun 17, 2024
@icewind1991 icewind1991 deleted the joblist-cleanup-by-id branch June 17, 2024 11:21
@icewind1991
Copy link
Member Author

/backport to stable29

@icewind1991
Copy link
Member Author

/backport to stable28

@icewind1991
Copy link
Member Author

/backport to stable27

* @param int $id
* @since 30.0.0
*/
public function removeById(int $id): void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Jul 18, 2024
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants