Skip to content

[stable28] fix(files): Ensure active file list entry is highlighted #45598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 3 commits into from
May 31, 2024
Merged

[stable28] fix(files): Ensure active file list entry is highlighted #45598

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d88d34c
fix(files): Ensure entry with `fileid` is marked as active
susnux May 30, 2024
4299f57
refactor(files): Consistently sort imports of FileEntryMixin
susnux May 30, 2024
a87f425
chore(assets): Recompile assets
nextcloud-command May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): Ensure entry with fileid is marked as active 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @backportbot
susnux authored and backportbot[bot] committed May 31, 2024
commit d88d34c5613b7c3e632d2845b3fba5d2f2d7f408
7 changes: 0 additions & 7 deletions apps/files/src/components/FileEntry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,13 +236,6 @@ export default defineComponent({
}
return ''
},

/**
* This entry is the current active node
*/
isActive() {
return this.fileid === this.currentFileId?.toString?.()
},
},

methods: {
Expand Down
2 changes: 1 addition & 1 deletion apps/files/src/components/FileEntryMixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export default defineComponent({
},

isActive() {
return this.fileid?.toString?.() === this.currentFileId?.toString?.()
return String(this.fileid) === String(this.currentFileId)
},

canDrag() {
Expand Down