-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(federatedfilesharing): import external federated share script #45606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| /** | ||
| * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-FileCopyrightText: 2014-2016 ownCloud, Inc. | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
| import { loadState } from '@nextcloud/initial-state' | ||
| import { generateUrl } from '@nextcloud/router' | ||
|
|
||
| window.OCA.Sharing = window.OCA.Sharing || {} | ||
|
|
||
| /** | ||
| * Shows "add external share" dialog. | ||
| * | ||
| * @param {object} share the share | ||
| * @param {string} share.remote remote server URL | ||
| * @param {string} share.owner owner name | ||
| * @param {string} share.name name of the shared folder | ||
| * @param {string} share.token authentication token | ||
| * @param {boolean} passwordProtected true if the share is password protected | ||
| * @param {Function} callback the callback | ||
| */ | ||
| window.OCA.Sharing.showAddExternalDialog = function(share, passwordProtected, callback) { | ||
| const remote = share.remote | ||
| const owner = share.ownerDisplayName || share.owner | ||
| const name = share.name | ||
|
|
||
| // Clean up the remote URL for display | ||
| const remoteClean = remote | ||
| .replace(/^https?:\/\//, '') // remove http:// or https:// | ||
| .replace(/\/$/, '') // remove trailing slash | ||
|
|
||
| if (!passwordProtected) { | ||
| window.OC.dialogs.confirm( | ||
| t( | ||
| 'files_sharing', | ||
| 'Do you want to add the remote share {name} from {owner}@{remote}?', | ||
| { name, owner, remote: remoteClean }, | ||
| ), | ||
| t('files_sharing', 'Remote share'), | ||
| function(result) { | ||
| callback(result, share) | ||
| }, | ||
| true, | ||
| ).then(this._adjustDialog) | ||
| } else { | ||
| window.OC.dialogs.prompt( | ||
| t( | ||
| 'files_sharing', | ||
| 'Do you want to add the remote share {name} from {owner}@{remote}?', | ||
| { name, owner, remote: remoteClean }, | ||
| ), | ||
| t('files_sharing', 'Remote share'), | ||
| function(result, password) { | ||
| share.password = password | ||
| callback(result, share) | ||
| }, | ||
| true, | ||
| t('files_sharing', 'Remote share password'), | ||
| true, | ||
| ).then(this._adjustDialog) | ||
| } | ||
| } | ||
|
|
||
| window.OCA.Sharing._adjustDialog = function() { | ||
| const $dialog = $('.oc-dialog:visible') | ||
| const $buttons = $dialog.find('button') | ||
| // hack the buttons | ||
| $dialog.find('.ui-icon').remove() | ||
| $buttons.eq(1).text(t('core', 'Cancel')) | ||
| $buttons.eq(2).text(t('files_sharing', 'Add remote share')) | ||
| } | ||
|
|
||
| const reloadFilesList = function() { | ||
| if (!window?.OCP?.Files?.Router?.goToRoute) { | ||
| // No router, just reload the page | ||
| window.location.reload() | ||
| return | ||
| } | ||
|
|
||
| // Let's redirect to the root as any accepted share would be there | ||
| window.OCP.Files.Router.goToRoute( | ||
| null, | ||
| { ...window.OCP.Files.Router.params, fileid: undefined }, | ||
| { ...window.OCP.Files.Router.query, dir: '/', openfile: undefined }, | ||
| ) | ||
| } | ||
|
|
||
| /** | ||
| * Process incoming remote share that might have been passed | ||
| * through the URL | ||
| */ | ||
| const processIncomingShareFromUrl = function() { | ||
| const params = window.OC.Util.History.parseUrlQuery() | ||
|
|
||
| // manually add server-to-server share | ||
| if (params.remote && params.token && params.name) { | ||
|
|
||
| const callbackAddShare = function(result, share) { | ||
| const password = share.password || '' | ||
| if (result) { | ||
| $.post( | ||
| generateUrl('apps/federatedfilesharing/askForFederatedShare'), | ||
| { | ||
| remote: share.remote, | ||
| token: share.token, | ||
| owner: share.owner, | ||
| ownerDisplayName: share.ownerDisplayName || share.owner, | ||
| name: share.name, | ||
| password, | ||
| }, | ||
| ).done(function(data) { | ||
| if (data.hasOwnProperty('legacyMount')) { | ||
| reloadFilesList() | ||
| } else { | ||
| window.OC.Notification.showTemporary(data.message) | ||
| } | ||
| }).fail(function(data) { | ||
| window.OC.Notification.showTemporary(JSON.parse(data.responseText).message) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| // clear hash, it is unlikely that it contain any extra parameters | ||
| location.hash = '' | ||
| params.passwordProtected = parseInt(params.protected, 10) === 1 | ||
| window.OCA.Sharing.showAddExternalDialog( | ||
| params, | ||
| params.passwordProtected, | ||
| callbackAddShare, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Retrieve a list of remote shares that need to be approved | ||
| */ | ||
| const processSharesToConfirm = function() { | ||
| // check for new server-to-server shares which need to be approved | ||
| $.get(generateUrl('/apps/files_sharing/api/externalShares'), {}, function(shares) { | ||
| let index | ||
| for (index = 0; index < shares.length; ++index) { | ||
| window.OCA.Sharing.showAddExternalDialog( | ||
| shares[index], | ||
| false, | ||
| function(result, share) { | ||
| if (result) { | ||
| // Accept | ||
| $.post(generateUrl('/apps/files_sharing/api/externalShares'), { id: share.id }) | ||
| .then(function() { | ||
| reloadFilesList() | ||
| }) | ||
| } else { | ||
| // Delete | ||
| $.ajax({ | ||
| url: generateUrl('/apps/files_sharing/api/externalShares/' + share.id), | ||
| type: 'DELETE', | ||
| }) | ||
| } | ||
| }, | ||
| ) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| processIncomingShareFromUrl() | ||
|
|
||
| if (loadState('federatedfilesharing', 'notificationsEnabled', true) !== true) { | ||
| // No notification app, display the modal | ||
| processSharesToConfirm() | ||
| } | ||
|
|
||
| $('body').on('window.OCA.Notification.Action', function(e) { | ||
| if (e.notification.app === 'files_sharing' && e.notification.object_type === 'remote_share' && e.action.type === 'POST') { | ||
| // User accepted a remote share reload | ||
| reloadFilesList() | ||
| } | ||
| }) | ||
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** | ||
| * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-FileCopyrightText: 2014-2016 ownCloud, Inc. | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ |
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be also updated to non-jquery code by now:
https://github.com/nextcloud/notifications/blob/master/src/Components/Action.vue#L131
Is needed anyway as we phase out jQuery and an issue got raised in notifications to either ship it's own or migrate away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be much refactored, but for now just restored the previously working module as it was in past