Skip to content

Conversation

@MorrisJobke
Copy link
Member

  • followup to Add more hints to settings #4540
  • @karlitschek proposed to not show Nextcloud in branded instances. If we do this then every single branded on (even if only the color is changed) will not show this text anymore. I guess we need to find another way to hide this. Because this is a user setting and allows the discovery of the feature.

@nickvergessen @juliushaertl @rullzer Any idea?

@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @jancborchardt and @LukasReschke to be potential reviewers.

@karlitschek
Copy link
Member

For all other hints i avoided mentioning Nextcloud at all. So this is all o.k. This is a special case. Maybe we keep on mentioning all three products in here. It is a shares standard after all. 👍 from me

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think we should be specific here, as said in the original issue. Especially federated sharing needs the explanation. ;)

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Apr 27, 2017
@MorrisJobke MorrisJobke merged commit 7b0ad3f into master Apr 27, 2017
@MorrisJobke MorrisJobke deleted the text-for-federated branch April 27, 2017 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews help wanted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants