Skip to content

[stable28] fix(INavigationManager): Fix psalm alias not set in the right place #45646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Altahrim merged 3 commits into from
Jun 5, 2024
Merged

[stable28] fix(INavigationManager): Fix psalm alias not set in the right place #45646

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43b0f1c
fix(INavigationManager): Fix psalm alias not set in the right place
provokateurin May 22, 2024
d96f8e0
fix(NavigationManager): Make entry order always an integer
provokateurin May 30, 2024
bba54b5
fix(core): Fix NavigationEntry typing
provokateurin May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(core): Fix NavigationEntry typing 
Signed-off-by: provokateurin <kate@provokateurin.de>
  • Loading branch information
@provokateurin
provokateurin committed Jun 4, 2024
commit bba54b55564dbf36c6602d6ebb4a7fe186f376c4
4 changes: 3 additions & 1 deletion core/ResponseDefinitions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,13 @@
*
* @psalm-type CoreNavigationEntry = array{
* id: string,
* order: int,
* order?: int,
* href: string,
* icon: string,
* type: string,
* name: string,
* app?: string,
* default?: bool,
* active: bool,
* classes: string,
* unread: int,
Expand Down
7 changes: 6 additions & 1 deletion core/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@
"type": "object",
"required": [
"id",
"order",
"href",
"icon",
"type",
Expand Down Expand Up @@ -211,6 +210,12 @@
"name": {
"type": "string"
},
"app": {
"type": "string"
},
"default": {
"type": "boolean"
},
"active": {
"type": "boolean"
},
Expand Down