Skip to content

dont spam log when request can't access filesystem #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Apr 29, 2017
Merged

dont spam log when request can't access filesystem #4566

MorrisJobke merged 1 commit into from
Apr 29, 2017

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Apr 27, 2017

Signed-off-by: Robin Appelman [email protected]

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 27, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone Apr 27, 2017
@mention-bot
Copy link

mention-bot commented Apr 27, 2017

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @bartv2 and @MorrisJobke to be potential reviewers.

@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 27, 2017

I guess this fixed #4288, right?

rullzer
rullzer approved these changes Apr 28, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised.

@codecov
Copy link

codecov bot commented Apr 28, 2017 •
edited
Loading

Codecov Report

Merging #4566 into master will increase coverage by 17.46%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #4566       +/-   ##
=============================================
+ Coverage     40.27%   57.74%   +17.46%     
- Complexity    19121    20223     +1102     
=============================================
  Files          1187     1194        +7     
  Lines         63664    68534     +4870     
=============================================
+ Hits          25640    39573    +13933     
+ Misses        38024    28961     -9063
Impacted Files Coverage Δ Complexity Δ
lib/base.php 3.09% <ø> (ø) 166 <0> (+1) ⬆️
apps/user_ldap/lib/Jobs/UpdateGroups.php 3.41% <0%> (-96.59%) 21% <0%> (+19%)
lib/private/Files/Node/NonExistingFolder.php 3.75% <0%> (-96.25%) 35% <0%> (+33%)
lib/private/Files/Node/NonExistingFile.php 9.09% <0%> (-90.91%) 28% <0%> (+24%)
apps/comments/appinfo/app.php 9.67% <0%> (-90.33%) 0% <0%> (ø)
apps/workflowengine/appinfo/routes.php 12.5% <0%> (-87.5%) 0% <0%> (ø)
apps/files/lib/Command/ScanAppData.php 13.63% <0%> (-86.37%) 33% <0%> (+31%)
apps/files/lib/Command/TransferOwnership.php 16.92% <0%> (-83.08%) 36% <0%> (+34%)
apps/federation/lib/SyncJob.php 22.22% <0%> (-77.78%) 5% <0%> (+4%)
apps/files_trashbin/lib/Command/ExpireTrash.php 22.44% <0%> (-77.56%) 12% <0%> (+10%)
... and 601 more

MorrisJobke
MorrisJobke approved these changes Apr 28, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - doesn't show any problems here too

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 28, 2017
@MorrisJobke MorrisJobke reopened this Apr 28, 2017
@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 28, 2017

Rebased to trigger CI

@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 29, 2017

I let the jobs run local -> merge

@MorrisJobke MorrisJobke merged commit 424d62d into master Apr 29, 2017
@MorrisJobke MorrisJobke deleted the cache-gc-no-fs branch April 29, 2017 02:11
@MorrisJobke MorrisJobke mentioned this pull request Apr 30, 2017
Closed
@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 30, 2017

@icewind1991 @LukasReschke Backport to stable11 because #4288 was scheduled for the 11 series?

@icewind1991 icewind1991 mentioned this pull request May 1, 2017
Merged
@icewind1991
Copy link
Member Author

icewind1991 commented May 1, 2017

#4622

This was referenced Sep 16, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991 @mention-bot @MorrisJobke @rullzer