fix(files_sharing): usage of NcTextField in SelectShareFolderDialogue #45679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/fix/error_with_share_folder_selection_form
branch
from
12b5508 to
3ef2c71
Compare
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
artonge
force-pushed
the
artonge/fix/error_with_share_folder_selection_form
branch
from
3ef2c71 to
63a9410
Compare
joshtrichards
approved these changes
Jun 5, 2024
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Tested. Works. LGTM.
Not sure how the screen shot in #40102 came about but maybe there was a change in the underlying library since?
The NcTextField needs a value property to be set. Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/error_with_share_folder_selection_form
branch
from
63a9410 to
914c4a2
Compare
szaimen
approved these changes
Jun 6, 2024
This was referenced Jun 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NcTextFieldneeds a value property to be set.