[stable27] fix(Session): avoid password confirmation on SSO #45703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
3. to review
artonge
approved these changes
Jun 10, 2024
AndyScherzinger
force-pushed
the
backport/43942/stable27
branch
from
6aa7177 to
f392255
Compare
blizzz
added
4. to release
blizzz
approved these changes
Jun 12, 2024
blizzz
force-pushed
the
backport/43942/stable27
branch
from
e58f635 to
ed13ab1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
Fixed
Show fixed
Hide fixed
lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
Fixed
Show fixed
Hide fixed
lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
Fixed
Show fixed
Hide fixed
blizzz
force-pushed
the
backport/43942/stable27
branch
from
ed13ab1 to
0689a82
Compare
Member
|
Pushed small adjustments (first commit is fixed up):
+use OC\Authentication\Exceptions\ExpiredTokenException;
+use OC\Authentication\Exceptions\InvalidTokenException;
+use OC\Authentication\Exceptions\WipeTokenException;
-use OCP\Authentication\Exceptions\ExpiredTokenException;
-use OCP\Authentication\Exceptions\InvalidTokenException;
-use OCP\Authentication\Exceptions\WipeTokenException;P.S.: and another similar change for the nodb unit tests diff --git a/tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php b/tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php
index 280a10fe90a..dd233dfa079 100644
--- a/tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php
+++ b/tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php
@@ -28,7 +28,7 @@ use OC\AppFramework\Middleware\Security\PasswordConfirmationMiddleware;
-use OCP\Authentication\Token\IToken;
+use OC\Authentication\Token\IToken; |
SSO backends like SAML and OIDC tried a trick to suppress password confirmations as they are not possible by design. At least for SAML it was not reliable when existing user backends where used as user repositories. Now we are setting a special scope with the token, and also make sure that the scope is taken over when tokens are regenerated. Signed-off-by: Arthur Schiwon <[email protected]>
- "password-unconfirmable" is the effective name for 30, but a draft name was backported. Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
backport/43942/stable27
branch
from
af765b6 to
495ccc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #43942 and #45809
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.