[stable29] fix(Session): avoid password confirmation on SSO #45705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
3. to review
blizzz
force-pushed
the
backport/43942/stable29
branch
from
760bbd1 to
4d123fd
Compare
artonge
approved these changes
Jun 10, 2024
SSO backends like SAML and OIDC tried a trick to suppress password confirmations as they are not possible by design. At least for SAML it was not reliable when existing user backends where used as user repositories. Now we are setting a special scope with the token, and also make sure that the scope is taken over when tokens are regenerated. Signed-off-by: Arthur Schiwon <[email protected]>
AndyScherzinger
force-pushed
the
backport/43942/stable29
branch
from
4b25121 to
f0494ec
Compare
ChristophWurst
approved these changes
Jun 12, 2024
blizzz
reviewed
Jun 12, 2024
| return; | ||
| } | ||
| $scope = $token->getScopeAsArray(); | ||
| if (isset($scope['sso-based-login']) && $scope['sso-based-login'] === true) { |
Member
There was a problem hiding this comment.
Just realized, the scope string is different in 30/master, password-unconfirmable, for the constants where introduced officially for 30 only, and there we had the changed name. I'll follow up with another PR to not introduce incompatibilities between 29 (and before) and 30.
4 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #43942
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.