fix(files_versions): renaming file version when its not a string

[sanskar-soni-9]

• Resolves: [Bug]: Naming File Version a number removes ability to edit version #45642

Summary

Naming a file version to a number (e.g. 1 or 1.0) is received as number type in the response object breaking the renaming of version as it needed to be a string

Todo

• Get the correct version name when its in float ending with '0' (e.g. 2.0 becomes 2 but 2.1 - 2.9 it will show correct version)

Before

After

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[joshtrichards]

/backport to stable29

[joshtrichards]

/backport to stable28

[artonge]

/compile /

[sanskar-soni-9]

Its failing, do I need to fix anything?

[artonge]

Its failing, do I need to fix anything?

Can you compile and commit the build files?

[sanskar-soni-9]

Its failing, do I need to fix anything?

Can you compile and commit the build files?

is this correct?

[artonge]

@sanskar-soni-9 and now the DCO :)
Also, CI is red, but probably unrelated to your changes, it should be fixed soon :).

[sanskar-soni-9]

@sanskar-soni-9 and now the DCO :) Also, CI is red, but probably unrelated to your changes, it should be fixed soon :).

sorry forgot to sign commit, in CI I saw its saying to run composer update should I do that and add those files too?

[artonge]

sorry forgot to sign commit, in CI I saw its saying to run composer update should I do that and add those files too?

No, this is the error I am referring to in my last comment. Ignore it for now, and we'll try to fix it on our side :).

[sanskar-soni-9]

sorry forgot to sign commit, in CI I saw its saying to run composer update should I do that and add those files too?

No, this is the error I am referring to in my last comment. Ignore it for now, and we'll try to fix it on our side :).

Okay, btw do I need to add build files with each PR. And Thanks a lot for helping 😊

[artonge]

do I need to add build files with each PR

In most repo, yes :). In doubt, just check the CI.

[sanskar-soni-9]

In most repo, yes :). In doubt, just check the CI.

Thanks for clarifying, will keep that in mind from next time :)

[artonge]

@sanskar-soni-9 can you rebase? You'll need to npm ci && npm run build during the conflict resolution.

[sanskar-soni-9]

@artonge done :)

[susnux]

@sanskar-soni-9 we need to merge this into a branch first to run the CI, but we will merge into master when green.
Thank you so much :)

[backportbot]

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/45733/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7e539f66 cd0bd9d3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45733/stable28

Error: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)