fix(settings): Use axios directly for health check to preven URL sanitizing #45765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
nfebe,
sorbaugh and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable28 |
grnd-alt
approved these changes
Jun 10, 2024
Contributor
Good finding! Who would expect that 🤷 I assume that should also fix #45378 and therefore added a link to it. |
8 tasks
Pytal
approved these changes
Jun 10, 2024
…tizing When using Apache with `DirectorySlash` it will respond with 301 and the URL with trailing slash. But when using traefik as the reverse proxy it can not rewrite redirects, this leads to the problem that the Apache response is using HTTP in the redirect but the real server (traefik) is only listening on HTTPS. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/health-check-traefik
branch
from
d21e3de to
00c077b
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Merged
2 tasks
1 task
Contributor
Author
|
/backport to stable30 |
Merged
2 tasks
8 tasks
Member
|
/backport 00c077b to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using Apache with
DirectorySlashit will respond with 301 and the URL with trailing slash. But when using traefik as the reverse proxy it can not rewrite redirects, this leads to the problem that the Apache response is using HTTP in the redirect but the real server (traefik) is only listening on HTTPS.The URL "sanitizing" of the "API" class rendered the current approach useless as it was removing the trailing slash again...
Checklist