Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jun 16, 2024

Summary

Basically this contains 3 notable changes:

  1. Use NcDateTime instead of moment to fix version dates not being translated correctly
  2. Allow version label and date to shrink to make the version entry readable on small screens (see screenshots below)
  3. Remove filters and replace them with computed values. Filters are deprecated and will make a migration to Vue 3 harder

Screenshots

before after
Bildschirmfoto_20240616_171442 Bildschirmfoto_20240616_171419

Checklist

@susnux
Copy link
Contributor Author

susnux commented Jun 16, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Jun 16, 2024

/backport to stable28

susnux added 2 commits June 17, 2024 09:22
…operly

Also do not use filters, filters are deprecated and will make migration to Vue 3 harder.

Signed-off-by: Ferdinand Thiessen <[email protected]>
…low viewing on small screens

Signed-off-by: Ferdinand Thiessen <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the fix/files-versions-date branch from 035d0bc to 9c67df1 Compare June 17, 2024 07:22
@AndyScherzinger
Copy link
Member

/compile /

@AndyScherzinger AndyScherzinger force-pushed the fix/files-versions-date branch from 9c67df1 to 78871a8 Compare June 17, 2024 07:29
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/files-versions-date branch from 78871a8 to 879120d Compare June 17, 2024 07:29
@susnux susnux merged commit 0b805ea into master Jun 17, 2024
@susnux susnux deleted the fix/files-versions-date branch June 17, 2024 09:22
@backportbot
Copy link

backportbot bot commented Jun 17, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/45900/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9f22538c 99262130 879120dd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45900/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Some translation missing

5 participants