Skip to content

ci: use precise ref for 3rdparty check #45912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Jun 17, 2024
Merged

ci: use precise ref for 3rdparty check #45912

blizzz merged 1 commit into from
Jun 17, 2024

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Jun 17, 2024

On stable29 we get wrong results, because more branches meet "stable29"

$ git ls-remote https://github.com/nextcloud/3rdparty stable29 
1706802f48993629baa7eb5520d098fed6dfb222        refs/heads/backport/1863/stable29
164fb3b7760f5cd2b9b5c1bdad7c74da1bcd3b68        refs/heads/stable29

Prefixing refs/heads/ solves this to provide the correct hash:

$ git ls-remote https://github.com/nextcloud/3rdparty refs/heads/stable29
164fb3b7760f5cd2b9b5c1bdad7c74da1bcd3b68        refs/heads/stable29

It will also work on master

$ git ls-remote https://github.com/nextcloud/3rdparty refs/heads/master
45d8fc9e09fbb4d3c4de5819afd9a6f72ce00f56        refs/heads/master

Provided the substitution still works 😅

@blizzz blizzz requested review from a team, ArtificialOwl, nickvergessen, sorbaugh and yemkareems and removed request for a team June 17, 2024 09:28
@blizzz blizzz added 3. to review Waiting for reviews tests Related to tests labels Jun 17, 2024
@blizzz
Copy link
Member Author

blizzz commented Jun 17, 2024

/backport to stable29

@blizzz
Copy link
Member Author

blizzz commented Jun 17, 2024

/backport to stable28

@blizzz
Copy link
Member Author

blizzz commented Jun 17, 2024

/backport to stable27

@blizzz
Copy link
Member Author

blizzz commented Jun 17, 2024

/backport to stable26

@blizzz
Copy link
Member Author

blizzz commented Jun 17, 2024

/backport to stable25

@blizzz
Copy link
Member Author

blizzz commented Jun 17, 2024

/backport to stable24

@blizzz blizzz merged commit 9872467 into master Jun 17, 2024
@blizzz blizzz deleted the fix/noid/3rdparty-check-ref branch June 17, 2024 14:32
This was referenced Jun 17, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@solracsf solracsf solracsf approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews tests Related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz @nickvergessen @solracsf