Skip to content

fix(files_sharing): global search in sharing tab #45922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ShGKme wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

fix(files_sharing): global search in sharing tab #45922

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf138c1
chore(files_sharing): use built-in label in search
ShGKme Jun 17, 2024
363221f
chore(files_sharing): remove unused method in SharingInput
ShGKme Jun 17, 2024
91da36b
fix(files_sharing): bring global search in Sharing Input
ShGKme Jun 17, 2024
5b3830c
chore(assets): Recompile assets
ShGKme Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(files_sharing): bring global search in Sharing Input 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
  • Loading branch information
@ShGKme
ShGKme committed Jun 21, 2024
commit 91da36bae43c71ff3de9bc046c82ad9413b6b1b1
14 changes: 13 additions & 1 deletion apps/files_sharing/src/components/SharingInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,20 @@ export default {
},

methods: {
onSelected(option) {
async onSelected(option) {
this.value = null // Reset selected option

// Not a real option, but a lookup = global search button
if (option.lookup) {
await this.getSuggestions(this.query, true)
// Wait until select is re-rendered with new options
await this.$nextTick()
// Open the select again
this.$refs.select.$children[0].open = true

return
}

this.openSharingDetails(option)
},

Expand Down