Skip to content

Conversation

@thlehmann-ionos
Copy link
Contributor

@thlehmann-ionos thlehmann-ionos commented Jun 19, 2024

Summary

The "redirects" config allows configuring redirects from paths to routes.

Example config

"redirects" => { "^/path/regexp" => "an.apps.controller.route.locator" }

Use case

  • An administrator can configure another app as target for certain paths.

Differentiation from Apache redirects

  • this allows configuring redirects in one place and avoids spreading
    the configuration in multiple places.
  • the target route locator is more expressive/easier to trace than a
    path

TODO

  • Tests
  • Documentation
  • Backport to stable29

Checklist

---
POC: Tests will be added once this proposal is accepted
---

The "redirects" config allows configuring redirects from paths to routes.

Example config:

   "redirects" => { "^/path/regexp" => "an.apps.controller.route.locator" }

Use case:

* An administrator can configure another app as target for certain paths.

Differentiation from Apache redirects:

* this allows configuring redirects in one place and avoids spreading
  the configuration in multiple places.

* the target route locator is more expressive/easier to trace than a
  path

Signed-off-by: Thomas Lehmann <[email protected]>
@thlehmann-ionos thlehmann-ionos force-pushed the redirect-config-proposal branch from 42bd04f to aa3d392 Compare June 19, 2024 14:59
@nickvergessen
Copy link
Member

This has quite some potential for misconfiguration that will break the UX (app removes/renames it's route/controller/method, typo in the origin/target, looping to the same page, …)
Any specific reason why this is better within Nextcloud instead of on webserver/proxy level?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv skjnldsv modified the milestone: Nextcloud 32 Jan 30, 2025
@susnux susnux added this to the Nextcloud 29.0.14 milestone Mar 2, 2025
@Altahrim Altahrim mentioned this pull request Mar 18, 2025
28 tasks
@blizzz blizzz mentioned this pull request Mar 19, 2025
This was referenced Apr 3, 2025
@skjnldsv skjnldsv mentioned this pull request Apr 10, 2025
15 tasks
@skjnldsv
Copy link
Member

29 is now EOL

@skjnldsv skjnldsv closed this Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants