Skip to content

[stable29] Don't trigger action when renaming #46018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 2 commits into from
Jul 1, 2024
Merged

[stable29] Don't trigger action when renaming #46018

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a91d44b
fix(files): Don't react to clicks when renaming
artonge Jun 19, 2024
42d0f52
chore(assets): Recompile assets
nextcloud-command Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): Don't react to clicks when renaming 
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed Jul 1, 2024
commit a91d44b15e44a744c2d6f80c708f6f8383d57ada
9 changes: 9 additions & 0 deletions apps/files/src/components/FileEntryMixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,10 @@ export default defineComponent({
this.actionsMenuStore.opened = opened ? this.uniqueId.toString() : null
},
},

isRenaming() {
return this.renamingStore.renamingNode === this.source
},
},

watch: {
Expand Down Expand Up @@ -225,6 +229,11 @@ export default defineComponent({
},

execDefaultAction(event) {
// Ignore click if we are renaming
if (this.isRenaming) {
return
}

// Ignore right click.
if (event.button > 1) {
return
Expand Down