Skip to content

fix(mail): Log hint when mail_from_address may be wrong #46040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(mail): Log hint when mail_from_address may be wrong #46040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/public/Util.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ public static function getDefaultEmailAddress(string $user_part): string {
return $defaultEmailAddress;
}

// in case we cannot build a valid email address from the hostname let's fallback to 'localhost.localdomain'
// in case we cannot build a valid email address from the hostname we log an error and fallback to 'localhost.localdomain' for now
\OCP\Server::get(LoggerInterface::class)->error('Unable to determine default email address ("mail_from_address" may be wrong). Using ' . $user_part . '@localhost.localdomain for the time being.');
return $user_part.'@localhost.localdomain';
}

Expand Down