Skip to content

[stable28] fix(FilesView): Update files view upon share creation/delete #46118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfebe merged 3 commits into from
Jul 9, 2024
Merged

[stable28] fix(FilesView): Update files view upon share creation/delete #46118

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d1431c
fix(FilesView): Update files view upon share creation/delete
nfebe Jun 21, 2024
4c25c02
refactor(SharingDetailsView): Use NC logger
nfebe Jun 21, 2024
9eb1269
chore(assets): Recompile assets
nextcloud-command Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(SharingDetailsView): Use NC logger 
Signed-off-by: fenn-cs <[email protected]>
  • Loading branch information
@nfebe
nfebe committed Jul 8, 2024
commit 4c25c02fd97dccc9d0b2f8fdc6ae2f62e6c5e5cc
8 changes: 4 additions & 4 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,8 +681,8 @@ export default {
beforeMount() {
this.initializePermissions()
this.initializeAttributes()
console.debug('shareSentIn', this.share)
console.debug('config', this.config)
logger.debug('Share object received', { share: this.share })
logger.debug('Configuration object received', { config: this.config })
},

mounted() {
Expand Down Expand Up @@ -858,7 +858,7 @@ export default {
* @param {Share} share incoming share object
*/
async addShare(share) {
console.debug('Adding a new share from the input for', share)
logger.debug('Adding a new share from the input for', { share })
const path = this.path
try {
const resultingShare = await this.createShare({
Expand All @@ -873,7 +873,7 @@ export default {
})
return resultingShare
} catch (error) {
console.error('Error while adding new share', error)
logger.error('Error while adding new share', { error })
} finally {
// this.loading = false // No loader here yet
}
Expand Down