Skip to content

ci: Adjust database versions to current LTS / supported versions #46121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 3 commits into from
Jun 28, 2024
Merged

ci: Adjust database versions to current LTS / supported versions #46121

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5d180d
ci: Adjust database versions to current LTS / supported versions
susnux Jun 25, 2024
6e48ca1
fix(settings): Adjust SetupCheck for supported database versions
susnux Jun 25, 2024
6601adc
refactor(SetupCheck): Make mariadb and mysql version variables
susnux Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor(SetupCheck): Make mariadb and mysql version variables 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Jun 27, 2024
commit 6601adcd6da33e3f8745156264ceb75b1958eff5
42 changes: 37 additions & 5 deletions apps/settings/lib/SetupChecks/SupportedDatabase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@
use OCP\SetupCheck\SetupResult;

class SupportedDatabase implements ISetupCheck {

private const MIN_MARIADB = '10.6';
private const MAX_MARIADB = '11.4';
private const MIN_MYSQL = '8.0';
private const MAX_MYSQL = '8.4';

public function __construct(
private IL10N $l10n,
private IURLGenerator $urlGenerator,
Expand Down Expand Up @@ -48,13 +54,39 @@ public function run(): SetupResult {
$versionConcern = $major . '.' . $minor;
if (str_contains($versionlc, 'mariadb')) {
if (version_compare($versionConcern, '10.3', '=')) {
return SetupResult::info($this->l10n->t('MariaDB version 10.3 detected, this version is end-of-life and only supported as part of Ubuntu 20.04. MariaDB >=10.6 and <=11.4 is suggested for best performance, stability and functionality with this version of Nextcloud.'));
} elseif (version_compare($versionConcern, '10.6', '<') || version_compare($versionConcern, '11.4', '>')) {
return SetupResult::warning($this->l10n->t('MariaDB version "%s" detected. MariaDB >=10.6 and <=11.4 is suggested for best performance, stability and functionality with this version of Nextcloud.', $version));
return SetupResult::info(
$this->l10n->t(
'MariaDB version 10.3 detected, this version is end-of-life and only supported as part of Ubuntu 20.04. MariaDB >=%1$s and <=%2$s is suggested for best performance, stability and functionality with this version of Nextcloud.',
[
self::MIN_MARIADB,
self::MAX_MARIADB,
]
),
);
} elseif (version_compare($versionConcern, self::MIN_MARIADB, '<') || version_compare($versionConcern, self::MAX_MARIADB, '>')) {
return SetupResult::warning(
$this->l10n->t(
'MariaDB version "%1$s" detected. MariaDB >=%2$s and <=%3$s is suggested for best performance, stability and functionality with this version of Nextcloud.',
[
$version,
self::MIN_MARIADB,
self::MAX_MARIADB,
],
),
);
}
} else {
if (version_compare($versionConcern, '8.0', '<') || version_compare($versionConcern, '8.4', '>')) {
return SetupResult::warning($this->l10n->t('MySQL version "%s" detected. MySQL >=8.0 and <=8.4 is suggested for best performance, stability and functionality with this version of Nextcloud.', $version));
if (version_compare($versionConcern, self::MIN_MYSQL, '<') || version_compare($versionConcern, self::MAX_MYSQL, '>')) {
return SetupResult::warning(
$this->l10n->t(
'MySQL version "%1$s" detected. MySQL >=%2$s and <=%3$s is suggested for best performance, stability and functionality with this version of Nextcloud.',
[
$version,
self::MIN_MYSQL,
self::MAX_MYSQL,
],
),
);
}
}
} elseif ($databasePlatform instanceof PostgreSQLPlatform) {
Expand Down