[stable29] fix(theming): Also provide default image as background by absolut URL #46211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a regression that for the default theme the image was not set as the background. Also the background was not always an absolut URL, only for custom images it was absolut, for default images / shipped images it was relative. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
a team,
ArtificialOwl,
provokateurin,
sorbaugh and
yemkareems
and removed request for
a team
provokateurin
approved these changes
Jul 1, 2024
Merged
sorbaugh
approved these changes
Jul 10, 2024
susnux
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a regression that for the default theme the image was not set as the background. Also the background was not always an absolute URL, only for custom images it was absolute, for default images / shipped images it was relative.
Checklist