Skip to content

Conversation

@Koc
Copy link
Contributor

@Koc Koc commented Jul 4, 2024

Summary

I've added information about user which downloaded file via public link (if this user was logged in)

image

Checklist

@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch 2 times, most recently from e60846f to bdbd494 Compare July 4, 2024 16:58
@kesselb kesselb added enhancement 3. to review Waiting for reviews labels Jul 4, 2024
@kesselb kesselb added this to the Nextcloud 30 milestone Jul 4, 2024
@kesselb kesselb requested review from Altahrim, artonge and szaimen July 4, 2024 18:47
@Koc
Copy link
Contributor Author

Koc commented Jul 5, 2024

@kesselb can you run pipeline for PR?

@Koc
Copy link
Contributor Author

Koc commented Jul 5, 2024

mates, seems like some test failures are unrelated to my changes. How can we fix them?

@kesselb
Copy link
Contributor

kesselb commented Jul 5, 2024

Ignore performance and cypress for now.

@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch from bdbd494 to d9c33af Compare July 9, 2024 22:56
@szaimen szaimen removed their request for review July 10, 2024 09:31
@Koc
Copy link
Contributor Author

Koc commented Jul 10, 2024

@kesselb all green 🟢, except performance and cypress

@artonge artonge force-pushed the feature/improve-file-download-activity-logging branch from d9c33af to 6e9b00f Compare July 11, 2024 07:17
@artonge
Copy link
Contributor

artonge commented Jul 11, 2024

Rebased

@Koc
Copy link
Contributor Author

Koc commented Jul 15, 2024

@artonge so, let's merge then?

@artonge
Copy link
Contributor

artonge commented Jul 15, 2024

@Koc sure, I created a local copy of your PR here: #46533
This is to have the result of all the CI steps.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@susnux susnux force-pushed the feature/improve-file-download-activity-logging branch from 6e9b00f to 287fb2d Compare July 26, 2024 14:24
This was referenced Jul 30, 2024
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 6, 2024
@blizzz blizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
@Altahrim Altahrim mentioned this pull request Jan 21, 2025
@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch from 1d9fff1 to 447fedd Compare January 23, 2025 01:12
@skjnldsv skjnldsv modified the milestones: Nextcloud 31, Nextcloud 32 Jan 23, 2025
@susnux
Copy link
Contributor

susnux commented Apr 23, 2025

@Koc can you rebase? It conflicts since #51458

@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch from 447fedd to a75cf28 Compare April 29, 2025 13:33
@Koc Koc requested a review from a team as a code owner April 29, 2025 13:33
@Koc Koc requested review from ArtificialOwl and icewind1991 and removed request for a team April 29, 2025 13:33
Signed-off-by: Konstantin Myakshin <[email protected]>
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch from a75cf28 to 8e8870c Compare April 29, 2025 13:42
@Koc
Copy link
Contributor Author

Koc commented Apr 29, 2025

@susnux I did the rebase but PR not works anymore because of setIncognitoMode usage somewhere in controlers/web dav internals 😕

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 1, 2025
This was referenced Aug 22, 2025
This was referenced Sep 2, 2025
This was referenced Sep 25, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 📄 To do (~10 entries)

Development

Successfully merging this pull request may close these issues.

6 participants