[stable28] fix(s3): Don't wait indefinitely for S3 to return #46366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Git'Fellow <[email protected]> fix: lint Signed-off-by: Git'Fellow <[email protected]> fix: use AwsException Signed-off-by: Git'Fellow <[email protected]> fix: Throw on connection failure Signed-off-by: Git'Fellow <[email protected]> fix: Wrap all in try catch block Signed-off-by: Git'Fellow <[email protected]> fix: use RequestTimeout error message Signed-off-by: Git'Fellow <[email protected]> log: use OCP Server class Signed-off-by: Git'Fellow <[email protected]> fix: Handle connect timeout only Signed-off-by: Git'Fellow <[email protected]> fix: Handle errors more generically Signed-off-by: Git'Fellow <[email protected]>
solracsf
approved these changes
Jul 9, 2024
come-nc
approved these changes
Jul 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #46317