Skip to content

feat: don't count failed CSRF as failed login attempt #46392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Altahrim merged 1 commit into from
Jul 11, 2024
Merged

feat: don't count failed CSRF as failed login attempt #46392

Altahrim merged 1 commit into from
Jul 11, 2024

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Jul 10, 2024 •
edited
Loading

Summary

Don't count failed CSRF as a failed login attempt

Checklist

@Altahrim Altahrim added enhancement 3. to review Waiting for reviews php Pull requests that update Php code labels Jul 10, 2024
@Altahrim Altahrim added this to the Nextcloud 30 milestone Jul 10, 2024
@Altahrim Altahrim self-assigned this Jul 10, 2024
@Altahrim
Copy link
Collaborator Author

Altahrim commented Jul 10, 2024

/backport to stable29

@Altahrim
Copy link
Collaborator Author

Altahrim commented Jul 10, 2024

/backport to stable28

@Altahrim Altahrim requested review from a team, ArtificialOwl, ChristophWurst, nickvergessen, sorbaugh and yemkareems and removed request for a team July 10, 2024 12:10
@Altahrim Altahrim force-pushed the chore/bruteforce-dont-count-failed-csrf branch 2 times, most recently from 07e353d to 8e28582 Compare July 10, 2024 14:12
@Altahrim Altahrim enabled auto-merge July 10, 2024 14:47
@Altahrim Altahrim force-pushed the chore/bruteforce-dont-count-failed-csrf branch from 8e28582 to 916e091 Compare July 10, 2024 19:31
@Altahrim Altahrim force-pushed the chore/bruteforce-dont-count-failed-csrf branch from 916e091 to e5275db Compare July 11, 2024 07:27
@Altahrim Altahrim disabled auto-merge July 11, 2024 09:19
@Altahrim Altahrim merged commit d526d78 into master Jul 11, 2024
@Altahrim Altahrim deleted the chore/bruteforce-dont-count-failed-csrf branch July 11, 2024 09:20
This was referenced Jul 11, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@yemkareems yemkareems yemkareems approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels

3. to review Waiting for reviews enhancement php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

4 participants

@Altahrim @nickvergessen @yemkareems